Skip to content

bpo-38100: Spelling error in unittest.mock code #16168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

marcoramirezmx
Copy link
Contributor

@marcoramirezmx marcoramirezmx commented Sep 15, 2019

Spelling error in unittest.mock code

Spelling correction in the unittest.mock library, "return_calulator" replaced with "return_calculator" in the _set_return_value method in Lib/unittest/mock.py.

https://bugs.python.org/issue38100

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@marcoramirezmx

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

There are two PRs for the issue and #16164 seems to be the first PR as per timestamp.

@matrixise
Copy link
Member

@tirkarthi sure but I think we will take the first one where the CLA is signed.

@miss-islington
Copy link
Contributor

Thanks @marcoramirezmx for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16191 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 16, 2019
(cherry picked from commit a9187c3)

Co-authored-by: marcoramirezmx <55331462+marcoramirezmx@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Thanks @marcoramirezmx for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @marcoramirezmx and @matrixise, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a9187c31185fe7ea47271839898416400cc3d976 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants