-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142927: Auto-open HTML output in browser after generation #143178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivonastojanovic
wants to merge
2
commits into
python:main
Choose a base branch
from
ivonastojanovic:auto_open_browser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically open flamegraph and heatmap HTML output in the default browser after profiling completes. Add --no-browser flag to disable this behavior.
Member
|
You probably need to update the test to NOT open the browser by default and make the CLI the only that sets that option to True :) |
Member
|
Changing the issue to gh-142927 |
Member
|
And we also need to mention something related to this behavior in the docs |
pablogsal
reviewed
Dec 25, 2025
pablogsal
reviewed
Dec 25, 2025
Member
|
Some tests re opening browsers now 😆 You probably want this diff at least: diff --git a/Lib/test/test_profiling/test_sampling_profiler/test_children.py b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
index b7dc878a238..3d6db7dcb56 100644
--- a/Lib/test/test_profiling/test_sampling_profiler/test_children.py
+++ b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
@@ -992,6 +992,7 @@ def test_subprocesses_flag_with_flamegraph_output(self):
"-r",
"100",
"--flamegraph",
+ "--no-browser",
"-o",
output_file,
script_file, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically open flamegraph and heatmap HTML output in the default browser after profiling completes. Add
--no-browserflag to disable this behavior.Towards #142927.
CC: @pablogsal @lkollar