Skip to content

Conversation

@ivonastojanovic
Copy link
Contributor

@ivonastojanovic ivonastojanovic commented Dec 25, 2025

Automatically open flamegraph and heatmap HTML output in the default browser after profiling completes. Add --no-browser flag to disable this behavior.

Towards #142927.

CC: @pablogsal @lkollar

Automatically open flamegraph and heatmap HTML output in the default
browser after profiling completes. Add --no-browser flag to disable
this behavior.
@pablogsal
Copy link
Member

You probably need to update the test to NOT open the browser by default and make the CLI the only that sets that option to True :)

@pablogsal pablogsal changed the title gh-138122: Auto-open HTML output in browser after generation gh-142927: Auto-open HTML output in browser after generation Dec 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2025
11 tasks
@pablogsal
Copy link
Member

Changing the issue to gh-142927

@pablogsal
Copy link
Member

And we also need to mention something related to this behavior in the docs

@pablogsal
Copy link
Member

Some tests re opening browsers now 😆

You probably want this diff at least:

diff --git a/Lib/test/test_profiling/test_sampling_profiler/test_children.py b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
index b7dc878a238..3d6db7dcb56 100644
--- a/Lib/test/test_profiling/test_sampling_profiler/test_children.py
+++ b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
@@ -992,6 +992,7 @@ def test_subprocesses_flag_with_flamegraph_output(self):
                     "-r",
                     "100",
                     "--flamegraph",
+                    "--no-browser",
                     "-o",
                     output_file,
                     script_file,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants