gh-142975: During GC, mark frozen objects with a merged zero refcount for destruction #143156
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
topic-free-threading
needs backport to 3.14
colesbury
approved these changes
Dec 25, 2025
Python/gc_free_threading.c
Outdated
| { | ||
| if (!_PyObject_GC_IS_TRACKED(op)) { | ||
| assert(Py_REFCNT(op) == 0); | ||
| // We have to treat frozen objects as untracked in this function or else |
Contributor
There was a problem hiding this comment.
I'd add a reference to the issue here. The description there is helpful as well.
// gh-142975: We have to ...
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 25, 2025
…fcount for destruction (pythonGH-143156) (cherry picked from commit 8611f74e089d9ac9de84dd42be9d251db27889aa) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-143175 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate_refcounts: "tracked objects must have a reference count > 0" #142975