-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-140648: Make asyncio REPL respect the -I flag (isolated mode)
#143045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnslavik
wants to merge
7
commits into
python:main
Choose a base branch
from
johnslavik:asyncio-repl-respect-isolated-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−13
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
80a0d98
Make `-I` customizable in `spawn_repl`
johnslavik d54a98e
Add failing test
johnslavik 9b7ea66
Fix sibling test
johnslavik 0f72219
Respect isolated mode in the asyncio REPL
johnslavik ba5f584
Add news entry
johnslavik e44213e
Reorder tests to not mess with git blame
johnslavik 0436076
fixup! Fix sibling test
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2025-12-21-17-24-29.gh-issue-140648.i8dca6.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| The :mod:`asyncio` REPL now respects the :option:`-I` flag (isolated mode). | ||
| Previously, it would load and execute :envvar:`PYTHONSTARTUP` even if the | ||
| flag was set. Contributed by Bartosz Sławecki. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems unrelated
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explained in 9b7ea66. I can remove it if it's too unrelated, just thought that it would be a valuable change when touching this code region. If I were to make a separate PR for this, I don't think it would be that clear why it's good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asyncio repl and its tests are quite old and are modified rarely so I prefer to to avoid touching it unless it is necessary. this isn't true for rest of asyncio but repl is special and I am not very comfortable making changes to it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do believe it is necessary.
\r\r\ncan somehow seriously mess up line numbering in tracebacks on Windows. This exact fragment of code led me to confusion earlier, and I think fixing it to correctly use\nis a non-intrusive and preventative thing to do.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I understand where you're coming from, and we can keep it as is, and this won't be a problem until someone copies that incorrect approach over to somewhere else, like I did.
In this exact case I don't see any danger in simply preventing that from happening -- this is objectively wrong code with no public usage exposure whatsoever, so there is a fair reason for change to prevent even more confusion (which had already happened).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this up to you -- I'm fine with the status quo if that's better in your opinion. This bit is the least important in the entire PR.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also see line 302 where I applied the same unrelated change.