gh-64551: Add RFC 5034 AUTH support to poplib #142613

fatelei · 2025-12-12T07:10:39Z

Add RFC 5034 AUTH support to poplib

Issue: Add support for AUTH command to poplib #64551

📚 Documentation preview 📚: https://cpython-previews--142613.org.readthedocs.build/

diegorusso · 2025-12-12T09:07:19Z

Can you please rebase/merge your branch on top of main please?

fatelei · 2025-12-12T09:18:58Z

Can you please rebase/merge your branch on top of main please?

done

diegorusso · 2025-12-12T09:23:33Z

Can you please rebase/merge your branch on top of main please?

done

Thanks! I removed all the reviewers and added only the ones in the original issue.

Lib/poplib.py

bitdancer

Thanks for working on this! I have several suggestions, mostly about mimicing the smtplib API for consistency.

Lib/poplib.py

bedevere-app · 2025-12-24T23:03:17Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

aisk · 2025-12-25T02:36:27Z

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

fatelei · 2025-12-25T02:37:17Z

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

i rebase, but i can not push, so i force push, sorry

aisk · 2025-12-25T02:44:39Z

i rebase, but i can not push, so i force push, sorry

You can fetch the remote, then use git merge ... to merge the changes into your local branch, make further changes, and finally git push ... to the remote safely and without -f option.

picnixz · 2025-12-25T18:39:47Z

Lib/poplib.py

 import re
 import socket
 import sys
+import base64


Please keep the imports alphabetically sorted.

picnixz · 2025-12-25T18:39:57Z

Doc/library/poplib.rst

+   (``bytes`` or ``str``).  Return ``b'*'`` to abort the exchange.
+


Suggested change

(``bytes`` or ``str``). Return ``b'*'`` to abort the exchange.

(``bytes`` or ``str``). Return ``b'*'`` to abort the exchange.

.. versionadded:: next

picnixz · 2025-12-25T18:40:21Z

Doc/library/poplib.rst

+   If *initial_response* is provided (``bytes`` or ``str``), it is
+   base64-encoded and appended to the command after a single space.


Suggested change

If *initial_response* is provided (``bytes`` or ``str``), it is

base64-encoded and appended to the command after a single space.

If *initial_response* is provided (as :class:`bytes` or :class:`str`),

it is base64-encoded and appended to the command after a single space.

picnixz · 2025-12-25T18:41:14Z

Doc/library/poplib.rst

+   If *authobject* is provided, it is called with the server’s ``bytes``
+   challenge (already base64-decoded) and must return the client response
+   (``bytes`` or ``str``).  Return ``b'*'`` to abort the exchange.


Suggested change

If *authobject* is provided, it is called with the server’s ``bytes``

challenge (already base64-decoded) and must return the client response

(``bytes`` or ``str``). Return ``b'*'`` to abort the exchange.

If *authobject* is provided, it is called with the server’s ``bytes``

challenge (already base64-decoded) and must return the client response

as a :class:`bytes` or :class:`str`. If ``b'*'`` is returned, the exchange

is aborted.

picnixz · 2025-12-25T18:42:05Z

Lib/poplib.py

        """
        return self._shortcmd('PASS %s' % pswd)

-


Let's avoid changing unrelated code.

picnixz · 2025-12-25T18:47:32Z

Lib/poplib.py

+
+            auth_challenge_count += 1
+            if auth_challenge_count > _MAXCHALLENGE:
+                raise error_proto('Server AUTH mechanism infinite loop')


Is this the same message as in smtplib?

picnixz · 2025-12-25T18:48:39Z

Lib/poplib.py

+            resp = authobject(challenge)
+            if resp is None:
+                resp = b''


So, authobject is allowed to return None. Should it be documented? or is it only kept for parity with legacy implementation of smtplib?

picnixz · 2025-12-25T18:51:56Z

Lib/poplib.py

+    def auth_plain(self, user, password, authzid=''):
+        """Return an authobject suitable for SASL PLAIN.
+
+        Result is 'str'.
+        """


Suggested change

def auth_plain(self, user, password, authzid=''):

"""Return an authobject suitable for SASL PLAIN.

Result is 'str'.

"""

def auth_plain(self, user, password, authzid=''):

"""Return an authobject suitable for SASL PLAIN."""

Why was there "result is 'str'"? and before "result is 'response'"? was it LLM-generated?

picnixz · 2025-12-25T18:52:28Z

Lib/test/test_poplib.py

 # Modified by Giampaolo Rodola' to give poplib.POP3 and poplib.POP3_SSL
 # a real test suite
-
+import base64


Keep a blank line before import base64.

picnixz · 2025-12-25T18:53:13Z

Misc/NEWS.d/next/Library/2025-12-12-15-09-34.gh-issue-64551.NfWlQX.rst

@@ -0,0 +1 @@
+Add RFC 5034 AUTH support to poplib


Suggested change

Add RFC 5034 AUTH support to poplib

:mod:`poplib`: add :rfc:`5034` ``AUTH`` support.

fatelei requested a review from a team as a code owner December 12, 2025 07:10

bedevere-app bot mentioned this pull request Dec 12, 2025

Add support for AUTH command to poplib #64551

Open

bedevere-app bot added the awaiting review label Dec 12, 2025

fatelei force-pushed the poplib_auth branch from c53cc71 to b9cb54b Compare December 12, 2025 09:18

diegorusso requested review from bitdancer and warsaw and removed request for AA-Turner, FFY00, Fidget-Spinner, ZeroIntensity, brandtbucher, kumaraditya303, lysnikolaou, markshannon, pablogsal and picnixz December 12, 2025 09:21

aisk reviewed Dec 12, 2025

View reviewed changes

Lib/poplib.py Outdated Show resolved Hide resolved

picnixz self-requested a review December 12, 2025 13:12

bitdancer requested changes Dec 24, 2025

View reviewed changes

bedevere-app bot removed the awaiting review label Dec 24, 2025

bedevere-app bot added the awaiting changes label Dec 24, 2025

fatelei added 5 commits December 25, 2025 10:33

feat: pop3 lib support auth

5811d4d

fix: fix test poplib test block forever

58632f8

chore: update docstring for auth method

00aa3bf

chore: update auth method

6aa8b23

fix: fix review comment

a899e9c

fatelei force-pushed the poplib_auth branch from 759e1e7 to a899e9c Compare December 25, 2025 02:33

fix: fix pre commit error

f228676

picnixz requested changes Dec 25, 2025

View reviewed changes

		(``bytes`` or ``str``). Return ``b'*'`` to abort the exchange.

		If initial_response is provided (``bytes`` or ``str``), it is
		base64-encoded and appended to the command after a single space.

	Add RFC 5034 AUTH support to poplib
	:mod:`poplib`: add :rfc:`5034` ``AUTH`` support.

Uh oh!

gh-64551: Add RFC 5034 AUTH support to poplib #142613

Are you sure you want to change the base?

gh-64551: Add RFC 5034 AUTH support to poplib #142613

Conversation

fatelei commented Dec 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

diegorusso commented Dec 12, 2025

Uh oh!

fatelei commented Dec 12, 2025

Uh oh!

diegorusso commented Dec 12, 2025

Uh oh!

Uh oh!

bitdancer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Dec 24, 2025

Uh oh!

aisk commented Dec 25, 2025

Uh oh!

fatelei commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aisk commented Dec 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fatelei commented Dec 12, 2025 •

edited by github-actions bot

Loading

fatelei commented Dec 25, 2025 •

edited

Loading