GH-131296: fix clang-cl warning on Windows in sre.c #131593
Conversation
| @@ -92,7 +92,11 @@ static unsigned int sre_toupper(unsigned int ch) { | |||
| /* -------------------------------------------------------------------- */ | |||
|
|
|||
| #if defined(_MSC_VER) | |||
| #pragma optimize("agtw", on) /* doesn't seem to make much difference... */ | |||
| # if defined(__clang__) | |||
| # pragma optimize("", on) | |||
There was a problem hiding this comment.
Fix warning : unexpected argument 'agtw' to '#pragma optimize'; expected "" [-Wignored-pragmas]
| # if defined(__clang__) | ||
| # pragma optimize("", on) | ||
| # else | ||
| # pragma optimize("gt", on) /* doesn't seem to make much difference... */ |
There was a problem hiding this comment.
agtw has been used in PY_LOCAL_AGGRESSIVE until #87332. Quote from @gvanrossum #87332 (comment)
A coworker happened to look at our use of #pragma optimize() for Windows (VS 2017) and noticed:
unless there’s something I’m missing, the ‘a’ and ‘w’ portions of the string being passed to the optimize pragma are not doing anything; I’m pretty sure they’ve been useless for 10+ years. The ‘g’ means turn on global optimizations and the ‘t’ means optimize for “time” (i.e. speed). See the documentation at https://docs.microsoft.com/en-us/cpp/preprocessor/optimize?view=msvc-160
It was then changed to gt (https://github.com/python/cpython/pull/24485/files) and entirely removed in https://github.com/python/cpython/pull/32023/files.
I think this is a skip news?