gh-131357: Add a set of asserts to test.test_capi.test_bytearray #131554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Assert empty bytearray object for PyByteArray_Check. 2. Assert empty bytearray object for PyByteArray_CheckExact. 3. Assert 0-size bytearray object for PyByteArray_Size. 4. Assert empty bytearray object for PyByteArray_AsString. 5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat.
nybblista
changed the title
sobolevn
added
awaiting merge
needs backport to 3.12
|
Thanks @nybblista for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @nybblista for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @nybblista and @sobolevn, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2025
pythonGH-131554) add a set of asserts to test.test_capi.test_bytearray 1. Assert empty bytearray object for PyByteArray_Check. 2. Assert empty bytearray object for PyByteArray_CheckExact. 3. Assert 0-size bytearray object for PyByteArray_Size. 4. Assert empty bytearray object for PyByteArray_AsString. 5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat. (cherry picked from commit f3bf304) Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
|
GH-131601 is a backport of this pull request to the 3.13 branch. |
|
@nybblista can you please do a manual 3.12 backport? |
sobolevn
pushed a commit
that referenced
this pull request
Mar 23, 2025
…ay (GH-131554) (#131601) gh-131357: Add a set of asserts to test.test_capi.test_bytearray (GH-131554) add a set of asserts to test.test_capi.test_bytearray 1. Assert empty bytearray object for PyByteArray_Check. 2. Assert empty bytearray object for PyByteArray_CheckExact. 3. Assert 0-size bytearray object for PyByteArray_Size. 4. Assert empty bytearray object for PyByteArray_AsString. 5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat. (cherry picked from commit f3bf304) Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
|
|
GH-131629 is a backport of this pull request to the 3.12 branch. |
sobolevn
pushed a commit
that referenced
this pull request
Mar 23, 2025
…ay (GH-131554) (#131629) [3.12] gh-131357: Add a set of asserts to test.test_capi.test_bytearray (#131554) add a set of asserts to test.test_capi.test_bytearray 1. Assert empty bytearray object for PyByteArray_Check. 2. Assert empty bytearray object for PyByteArray_CheckExact. 3. Assert 0-size bytearray object for PyByteArray_Size. 4. Assert empty bytearray object for PyByteArray_AsString. 5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat. (cherry picked from commit f3bf304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyByteArray_Check.PyByteArray_CheckExact.PyByteArray_Size.PyByteArray_AsString.PyByteArray_Concat.capitests #131357