Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124666: Improve thread cleanup in test_android #131427

Merged
merged 1 commit into from
Mar 18, 2025
Merged

gh-124666: Improve thread cleanup in test_android #131427

merged 1 commit into from
Mar 18, 2025
+26 −13

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Mar 18, 2025 •
edited
Loading

The hanging buildbot in #124666 was caused by a leftover thread created in the test's setUp method. It was supposed to be cleaned up by tearDown, but that isn't called automatically when setUp fails.

I still don't know why the underlying test failure was happening, but I've increased all the timeouts to LOOPBACK_TIMEOUT (10 seconds) in case that makes a difference.

Also cleaned up a couple of other test failure logging issues.

@mhsmith
Improve thread cleanup in test_android
Loading
Loading status checks…
4997d1b
@mhsmith mhsmith added skip news needs backport to 3.13 bugs and security fixes labels Mar 18, 2025
@mhsmith mhsmith requested a review from freakboy3742 as a code owner March 18, 2025 19:45
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 18, 2025
Closed
@mhsmith
Copy link
Member Author

mhsmith commented Mar 18, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4997d1b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131427%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

freakboy3742
freakboy3742 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable set of fixes to me. If nothing else, I guess this means the failure case will actually fail, rather than timing out, which is a definite improvement; maybe the new failure will reveal more detail about why it's failing? (We can but hope :-) )

@freakboy3742 freakboy3742 merged commit 01b5abb into python:main Mar 18, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
@mhsmith @miss-islington
pythongh-124666: Improve thread cleanup in test_android (pythonGH-131427
Loading
Loading status checks…
7f13df4 
)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 18, 2025

GH-131433 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2025
freakboy3742 pushed a commit that referenced this pull request Mar 19, 2025
@miss-islington @mhsmith
[3.13] gh-124666: Improve thread cleanup in test_android (GH-131427) (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ff286a3 
…131433)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@mhsmith @colesbury
pythongh-124666: Improve thread cleanup in test_android (python#131427)
1a2d35e 
Ensures that failures in test setup don't result in dangling threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent buildbot failure and timeout on Android aarch64
3 participants
@mhsmith @bedevere-bot @freakboy3742