gh-130149: cleanup refactorization of test_hmac.py
#131318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `requires_builtin_hmac` to check if built-in HMAC is available - refactor `requires_hashdigest` in prevision of a future `requires_builtin_hashdigest` for built-in hashes only
- update comments for `CreatorMixin.hmac_new()` - update comments for `DigestMixin.hmac_digest()` - update comments for `TestVectorsMixin` - update comments for `TestVectorsMixin.hmac_new_by_name()` - update comments for `TestVectorsMixin.hmac_digest_by_name()`
* `assert_hmac_hexdigest_by_new` -> `assert_hmac_hexdigest_by_name` * use a single function for checking the hexdigest.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
picnixz
force-pushed
the
feat/test/hmac-130149
branch
from
89eadce to
3ea207e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
Failed tests are: Those tests are failing for the past year. It's virtually impossible to easily make them succeed because |
picnixz
commented
Mar 16, 2025
gpshead
approved these changes
Mar 17, 2025
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…1318) New features: * refactor `hashlib_helper.requires_hashdigest` in prevision of a future `hashlib_helper.requires_builtin_hashdigest` for built-in hashes only * add `hashlib_helper.requires_openssl_hashdigest` to request OpenSSL hashes, assuming that `_hashlib` exists. Refactoring: * split hmac.copy() test by implementation * update how algorithms are discovered for RFC test cases * simplify how OpenSSL hash digests are requested * refactor hexdigest tests for RFC test vectors * typo fix: `assert_hmac_hexdigest_by_new` -> `assert_hmac_hexdigest_by_name` Improvements: * strengthen contract on `hmac_new_by_name` and `hmac_digest_by_name` * rename mixin classes to better match their responsibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting some changes from #130157 so that I don't need to put them out there.