Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-130931: Add pycore_interpframe.h internal header #131249

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 14, 2025

Move _PyInterpreterFrame and associated functions to a new pycore_interpframe.h header.

@vstinner
Copy link
Member Author

This PR now needs #131396. I rebased this PR on top of PR gh-131396 and marked it as a draft to wait until PR gh-131396 is merged.

@vstinner vstinner force-pushed the pycore_interpframe branch 2 times, most recently from 8660a4a to 8161a9b Compare March 19, 2025 15:14
Move _PyInterpreterFrame and associated functions
to a new pycore_interpframe.h header.
@vstinner vstinner force-pushed the pycore_interpframe branch from 8161a9b to 0d60edb Compare March 19, 2025 15:15
@vstinner vstinner marked this pull request as ready for review March 19, 2025 15:45
@vstinner
Copy link
Member Author

@markshannon: Are you ok with this trade-off to unblock Cython for now?

@vstinner vstinner merged commit 5c44d7d into python:main Mar 19, 2025
43 checks passed
@vstinner vstinner deleted the pycore_interpframe branch March 19, 2025 17:17
@vstinner
Copy link
Member Author

@markshannon: Are you ok with this trade-off to unblock Cython for now?

See @markshannon's comment on the issue: #130931 (comment)

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 5c44d7d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/10633) and take a look at the build logs.
  4. Check if the failure is related to this commit (5c44d7d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/10633

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 34, done.        
remote: Counting objects:   2% (1/34)        
remote: Counting objects:   5% (2/34)        
remote: Counting objects:   8% (3/34)        
remote: Counting objects:  11% (4/34)        
remote: Counting objects:  14% (5/34)        
remote: Counting objects:  17% (6/34)        
remote: Counting objects:  20% (7/34)        
remote: Counting objects:  23% (8/34)        
remote: Counting objects:  26% (9/34)        
remote: Counting objects:  29% (10/34)        
remote: Counting objects:  32% (11/34)        
remote: Counting objects:  35% (12/34)        
remote: Counting objects:  38% (13/34)        
remote: Counting objects:  41% (14/34)        
remote: Counting objects:  44% (15/34)        
remote: Counting objects:  47% (16/34)        
remote: Counting objects:  50% (17/34)        
remote: Counting objects:  52% (18/34)        
remote: Counting objects:  55% (19/34)        
remote: Counting objects:  58% (20/34)        
remote: Counting objects:  61% (21/34)        
remote: Counting objects:  64% (22/34)        
remote: Counting objects:  67% (23/34)        
remote: Counting objects:  70% (24/34)        
remote: Counting objects:  73% (25/34)        
remote: Counting objects:  76% (26/34)        
remote: Counting objects:  79% (27/34)        
remote: Counting objects:  82% (28/34)        
remote: Counting objects:  85% (29/34)        
remote: Counting objects:  88% (30/34)        
remote: Counting objects:  91% (31/34)        
remote: Counting objects:  94% (32/34)        
remote: Counting objects:  97% (33/34)        
remote: Counting objects: 100% (34/34)        
remote: Counting objects: 100% (34/34), done.        
remote: Compressing objects:   6% (1/15)        
remote: Compressing objects:  13% (2/15)        
remote: Compressing objects:  20% (3/15)        
remote: Compressing objects:  26% (4/15)        
remote: Compressing objects:  33% (5/15)        
remote: Compressing objects:  40% (6/15)        
remote: Compressing objects:  46% (7/15)        
remote: Compressing objects:  53% (8/15)        
remote: Compressing objects:  60% (9/15)        
remote: Compressing objects:  66% (10/15)        
remote: Compressing objects:  73% (11/15)        
remote: Compressing objects:  80% (12/15)        
remote: Compressing objects:  86% (13/15)        
remote: Compressing objects:  93% (14/15)        
remote: Compressing objects: 100% (15/15)        
remote: Compressing objects: 100% (15/15), done.        
remote: Total 18 (delta 16), reused 4 (delta 3), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '5c44d7d99c470b4270b2f0e4841cf5a7f2499e15'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 5c44d7d99c4 gh-130931: Add pycore_interpframe.h internal header (#131249)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:3213: clean-retain-profile] Error 1 (ignored)

@colesbury
Copy link
Contributor

Would you please add this to PYTHON_HEADERS in Makefile.pre.in?

@vstinner
Copy link
Member Author

Would you please add this to PYTHON_HEADERS in Makefile.pre.in?

Oops, I was sure that I did! I wrote #131545 to add it to PYTHON_HEADERS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants