gh-131510: Deprecate PyUnicodeObject structs, revert memory layout #130697
+312
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `PyASCIIObject`, `PyCompactUnicodeObject`, `PyUnicodeObject` structs, and the `PyUnicode_IS_COMPACT` macro. Schedule removal for 3.16, the shortest non-exceptional deprecation period per PEP-387. The structs are blocking development of the free-threaded build (bitfields can't be used atomically) and of possible UTF-8-focused string representations. In non-free-threaded builds, revert `PyASCIIObject` to the binary layout used in 3.13. For free-threaded builds, use `alignas` instead of padding to ensure alignment. All relevant compilers support `alignas`, as do the C11 & C++11 standards, but they may need different spelling or compiler options for it.
|
Discussion: https://discuss.python.org/t/deprecating-the-pyasciiobject-struct/82543 I'll look at the compile errors later. (Thank you GHA; I can't easily do a matrix build locally.) |
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 500b483 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130697%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
encukou
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Draft for discussion with the C API WG.)
Deprecate
PyASCIIObject,PyCompactUnicodeObject,PyUnicodeObjectstructs, and thePyUnicode_IS_COMPACTmacro.Schedule removal for 3.16, the shortest non-exceptional deprecation period per PEP-387. The structs are blocking development of the free-threaded build (bitfields can't be used atomically) and of possible UTF-8-focused string representations.
Add an example of what I'd like to see in porting notes for a deprecation.
In non-free-threaded builds, revert
PyASCIIObjectto be ABI-compatible with in 3.13.For free-threaded builds, use
alignasinstead of padding to ensure alignment.All relevant compilers support
alignas, as do the C11 & C++11 standards, but they may need different spelling or compiler options for it.Introduce
_Py_ALIGN_ASfor this.📚 Documentation preview 📚: https://cpython-previews--130697.org.readthedocs.build/