gh-129354: Use PyErr_FormatUnraisable() function #129523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable(). Update tests: * test_coroutines * test_exceptions * test_generators * test_struct
|
This change removes the object argument of |
|
I extracted some changes which don't impact tests in #129656. |
serhiy-storchaka
approved these changes
Feb 5, 2025
| @@ -2411,10 +2413,13 @@ async def corofn(): | |||
| coro_repr = repr(coro) | |||
|
|
|||
| # clear reference to the coroutine without awaiting for it | |||
| coro_repr = repr(coro) | |||
There was a problem hiding this comment.
It is already evaluated three lines above.
There was a problem hiding this comment.
Oh sorry, I enabled automerge before you posted your review. I wrote #129684 to remove the duplicated variable and remove a few other minor similar issues.
|
Ah, you missed my comment. Not big deal, but now the test looks slightly dirty. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable(). Update tests: * test_coroutines * test_exceptions * test_generators * test_struct
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable(). Update tests: * test_coroutines * test_exceptions * test_generators * test_struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().
Update tests:
PyErr_WriteUnraisable()withPyErr_FormatUnraisable()#129354