Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert* comparison methods in test_timer_comparison #129513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use assert* comparison methods in test_timer_comparison #129513

wants to merge 1 commit into from
+41 −35

Conversation

alex-semenyuk
Copy link

Use assertLess, assertGreaterEqual etc. for test_timer_comparison to remove TODO

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jan 31, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jan 31, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 31, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@alex-semenyuk
Copy link
Author

friendly ping @1st1 @asvetlov @kumaraditya303 @willingc

@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@picnixz picnixz changed the title Fix TODO for test_timer_comparison Use assert* comparison methods in test_timer_comparison Mar 2, 2025
@alex-semenyuk alex-semenyuk force-pushed the fix-test_timer_comparison branch 2 times, most recently from 42a2eec to b8becb9 Compare March 20, 2025 22:12
@alex-semenyuk alex-semenyuk force-pushed the fix-test_timer_comparison branch from b8becb9 to fa9b647 Compare March 20, 2025 22:23
@alex-semenyuk
Copy link
Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Mar 21, 2025

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
awaiting change review skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-semenyuk @picnixz @kumaraditya303 @skirpichev