Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115999: Fix gdb support for libpython.so after thread-local bytecode change #126440

Merged
merged 1 commit into from
Nov 5, 2024
Merged

gh-115999: Fix gdb support for libpython.so after thread-local bytecode change #126440

merged 1 commit into from
Nov 5, 2024

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented Nov 5, 2024 •
edited by bedevere-app bot
Loading

Fix the gdb pretty printer in the face of --enable-shared by delaying the attempt to load the _PyInterpreterFrame definition (for thread-local bytecode detection) until after .so files are loaded.

@Yhg1s
Fix the gdb pretty printer in the face of --enable-shared by delaying…
e2202fc 
… the

attempt to load the _PyInterpreterFrame definition until after .so files are
loaded.
@Yhg1s Yhg1s added the skip news label Nov 5, 2024
@Yhg1s Yhg1s requested review from encukou and mpage November 5, 2024 12:03
@bedevere-app bedevere-app bot mentioned this pull request Nov 5, 2024
Open
@Yhg1s
Copy link
Member Author

Yhg1s commented Nov 5, 2024

!buildbot Shared

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @Yhg1s for commit e2202fc 🤖

The command will test the builders whose names match following regular expression: Shared

The builders matched are:

  • AMD64 Ubuntu Shared PR

@Yhg1s Yhg1s mentioned this pull request Nov 5, 2024
Merged
encukou
encukou approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Thank you for looking into this, and for the fix!

I could reproduce with --enable-shared, and this fixes the test for me.
Let's merge when the buildbot passes (in a few hours, there's a queue).

@Yhg1s
Copy link
Member Author

Yhg1s commented Nov 5, 2024

Looks like the buildbot passes: https://buildbot.python.org/?#/builders/500/builds/1523

@Yhg1s Yhg1s merged commit bbfd9c9 into python:main Nov 5, 2024
43 checks passed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@Yhg1s @picnixz
pythongh-115999: Fix gdb support for libpython.so after thread-local …
629e179 
…bytecode change (python#126440)

Fix the gdb pretty printer in the face of --enable-shared by delaying the attempt to load the _PyInterpreterFrame definition until after .so files are loaded.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@Yhg1s @ebonnal
pythongh-115999: Fix gdb support for libpython.so after thread-local …
dc08867 
…bytecode change (python#126440)

Fix the gdb pretty printer in the face of --enable-shared by delaying the attempt to load the _PyInterpreterFrame definition until after .so files are loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@mpage mpage Awaiting requested review from mpage

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yhg1s @bedevere-bot @encukou