[3.13] GH-125866: Improve tests for pathname2url() and url2pathname() (GH-125993)
#126144
+77
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` (pythonGH-125993) Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test only the Windows-specific implementations from `nturl2path`) into the main `Pathname_Tests` test case for these functions. Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`. (cherry picked from commit 6742f14) Co-authored-by: Barney Gale <barney.gale@gmail.com>
bedevere-app
bot
added
tests
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
URL2PathNameTestsandPathName2URLTeststest cases (which testonly the Windows-specific implementations from
nturl2path) into the mainPathname_Teststest case for these functions.Copy/port some test cases for
pathlib.Path.as_uri()andfrom_uri().(cherry picked from commit 6742f14)
Co-authored-by: Barney Gale barney.gale@gmail.com
urllib.request#125866