Skip to content

gh-120754: Ensure _stat_atopen is cleared on fd change #125166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 11 commits into from
Nov 1, 2024
Merged

gh-120754: Ensure _stat_atopen is cleared on fd change #125166

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d57abd0
gh-120754: _io Ensure stat cache is cleared on fd change
cmaloney Oct 8, 2024
d2cb365
gh-120754: _pyio ensure _stat_atopen is cleared on fd change
cmaloney Oct 8, 2024
854ae91
_io: Add curlies since already modifying if
cmaloney Oct 9, 2024
c6da86e
_io: Always clear self->stat_atopen
cmaloney Oct 9, 2024
0f64483
pyio: Always clear stat_atopen just before close
cmaloney Oct 9, 2024
e2eebb0
Remove assert accidentally commited
cmaloney Oct 9, 2024
5299a04
_io: fix conditional
cmaloney Oct 9, 2024
d749709
Clear before internal_close to match _pyio os.close callsites
cmaloney Oct 22, 2024
b429587
Move to conditional free, simplify code, drop comment
cmaloney Oct 30, 2024
f08defa
Merge branch 'main' into cmaloney/fd_cleanup
cmaloney Oct 30, 2024
e153d97
Apply review fixes
cmaloney Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove assert accidentally commited
  • Loading branch information
@cmaloney
cmaloney committed Oct 9, 2024
commit e2eebb061cb0ec6c7746dc35625ae69585590b4f
1 change: 0 additions & 1 deletion Modules/_io/fileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,6 @@ _io_FileIO___init___impl(fileio *self, PyObject *nameobj, const char *mode,
out the old fd (see: internal_close) should always nullify
self->stat_atopen before this point. Just in case though, to prevent
leaks, only allocate a new one if required. */
assert(self->stat_atopen == NULL)
if (self->stat_atopen != NULL) {
Copy link
Member

@vstinner vstinner Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyMem_Free(NULL) is well defined: it does nothing, so you might omit the if (stat_atopen != NULL) test.

self->stat_atopen = PyMem_New(struct _Py_stat_struct, 1);
if (self->stat_atopen == NULL) {
Expand Down