gh-124498: Fix TypeAliasType not to be generic, when type_params=()
#124499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
JelleZijlstra and
markshannon
as code owners
JelleZijlstra
approved these changes
Sep 26, 2024
| @@ -1914,7 +1914,16 @@ typealias_alloc(PyObject *name, PyObject *type_params, PyObject *compute_value, | |||
| return NULL; | |||
| } | |||
| ta->name = Py_NewRef(name); | |||
| ta->type_params = Py_IsNone(type_params) ? NULL : Py_XNewRef(type_params); | |||
| if ( | |||
| type_params == NULL | |||
There was a problem hiding this comment.
Can it ever be NULL? Can't hurt to have this check though.
There was a problem hiding this comment.
Old code assumed this path with Py_XNewRef, so I just followed the same style.
sobolevn
added
needs backport to 3.12
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2024
…rams=()` (pythonGH-124499) (cherry picked from commit abe5f79) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-124603 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2024
…rams=()` (pythonGH-124499) (cherry picked from commit abe5f79) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-124604 is a backport of this pull request to the 3.12 branch. |
sobolevn
added a commit
that referenced
this pull request
Sep 26, 2024
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Sep 26, 2024
Yhg1s
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type_params=()is passed. #124498