GH-115776: Allow any fixed sized object to have inline values #123192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Aug 21, 2024
Good point. |
markshannon
commented
Aug 21, 2024
|
It looks like this PR broke a test in the mypyc transpiler: python/mypy#17973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only objects with
Py_TYPE(obj)->tp_basicsize == sizeof(PyObject)are allowed to have inline values.This PR changes that to allow any object where all instances of the class have the same size to have inline values.
Performance is in the noise, but the stats show a clear reduction in the number of
LOAD_ATTRs executed.Oddly, the number of
LOAD_ATTR_INSTANCE_VALUEs executed is roughly unchanged, the new specializations being for class attributes. Fixing the shadowing issue should improve things further and show an increase inLOAD_ATTR_INSTANCE_VALUEs.