gh-121905: Consistently use "floating-point" instead of "floating point"#121907
gh-121905: Consistently use "floating-point" instead of "floating point"#121907serhiy-storchaka merged 8 commits intopython:mainfrom
Conversation
serhiy-storchaka
requested review from
a team,
abalkin,
corona10,
erlend-aasland,
iritkatriel,
lysnikolaou,
pablogsal,
pganssle and
rhettinger
as code owners
|
I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable. |
serhiy-storchaka
force-pushed
the
docs-floating-point
branch
from
2b42420 to
e659280
Compare
This is the correct distinction; your choices all look correct to me |
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
I've had a brief look through everything and can't spot any obvious problems. I agree re using the hyphenated form.
A
mdickinson
left a comment
mdickinson
left a comment
There was a problem hiding this comment.
Haven't reviewed line-by-line, but the change LGTM in principle.
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
…"floating point" (pythonGH-121907) (cherry picked from commit 1a0c7b9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-122012 is a backport of this pull request to the 3.13 branch. |
…ng point" (pythonGH-121907) (cherry picked from commit 1a0c7b9)
|
GH-122013 is a backport of this pull request to the 3.12 branch. |
5 participants
📚 Documentation preview 📚: https://cpython-previews--121907.org.readthedocs.build/