-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-73536: Add support for multi-signatures #117671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
serhiy-storchaka
wants to merge
16
commits into
python:main
Choose a base branch
from
serhiy-storchaka:wip-inspect-multi-signature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9247a46
gh-73536: Add support of multi-signatures
serhiy-storchaka 54db6d3
Add tests and fix errors.
serhiy-storchaka 9bbde5f
Fix signatures of hex() methods.
serhiy-storchaka 5c9ddb9
Refactor support of partial and partialmethod.
serhiy-storchaka 5e7ca6d
Update Lib/inspect.py
serhiy-storchaka 53bc04e
Remove old commented out code.
serhiy-storchaka 1a3536f
Add $module for builtin functions.
serhiy-storchaka 6ff7151
Tests signatures of methods. Fix more signatures in builtins, types a…
serhiy-storchaka 2ad265a
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 57f3abf
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 2227748
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 5df505a
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 087fd94
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 452bb6f
Add more tests.
serhiy-storchaka 5a70fb0
Merge branch 'main' into wip-inspect-multi-signature
serhiy-storchaka 5678904
Add signatures for FrameLocalsProxyType methods.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add tests and fix errors.
- Loading branch information
commit 54db6d3d75844fe66b9d12e21a8d165ee243494d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless the case of the list being empty is handled elsewhere, this could result in a
raise None. Maybe that None should instead be something likeException("Empty MultiSignature list")?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is checked in the constructor. I think even about removing this assignment, NameError is clearer indication if something goes wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.