gh-92123: Adapt _elementtree to multi-phase init (PEP 489) #101285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Jan 24, 2023
•
erlend-aasland
commented
- Issue: [subinterpreters] crash in _elementtree when parsing in parallel #92123
Pass state as arg to expat_set_error()
Pass state as arg to element_setstate_from_attributes()
Pass state as arg to element_setstate_from_Python()
erlend-aasland
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de8ec94 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
corona10
approved these changes
Jan 24, 2023
Thanks for the review; I'll merge as soon as the CI turns green. I'll give Kumar a chance to review it, so I'll wait with merging until tomorrow evening. |
kumaraditya303
approved these changes
Jan 24, 2023
|
Nicely done @erlend-aasland, that was a big one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.