Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building using "computed gotos" for clang-cl on Windows #131278

Closed
chris-eibl opened this issue Mar 15, 2025 · 1 comment
Closed

Support building using "computed gotos" for clang-cl on Windows #131278

chris-eibl opened this issue Mar 15, 2025 · 1 comment
Labels
build The build process and cross-build OS-windows performance Performance or resource usage type-feature A feature request or enhancement

Comments

@chris-eibl
Copy link
Contributor

chris-eibl commented Mar 15, 2025

Per suggestion from @zooba in #130040 (comment), don't be too fancy here:

  • just support a new optimizing build flag WITH_COMPUTED_GOTOS and keep build.bat out of the loop. It does not have to learn such flags. It already knows too many of them "which could just be passed through".
  • only test for != '' rather than a specific value.
  • no magic defaults - explicit is better than implicit. If it is there, it's enabled, else it's disabled.
  • but document like set WITH_COMPUTED_GOTOS=true
  • this would give us the possibility to opt out using WITH_COMPUTED_GOTOS=false, should we ever enable it by default (and the user does not like our guess)

Linked PRs

@picnixz picnixz added type-feature A feature request or enhancement performance Performance or resource usage OS-windows build The build process and cross-build labels Mar 15, 2025
zooba pushed a commit that referenced this issue Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ang-cl (GH-131279)
@zooba zooba closed this as completed Mar 17, 2025
@zooba
Copy link
Member

zooba commented Mar 17, 2025

Thanks!

colesbury pushed a commit to colesbury/cpython that referenced this issue Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-windows performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants