Skip to content

Conversation

soarer1004
Copy link

Add external files support. For example:

<script lang="ts" src="./bar.ts"></script>

@pyoner
Copy link
Owner

pyoner commented Jun 28, 2019

Hi @soarer1004 !
Can you make the PR without external dependencies path, fs?

@soarer1004
Copy link
Author

@pyoner

Can avoid usage of fs, but i don't know how get path of script file without path.

Copy link
Owner

@pyoner pyoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to include path and fs to package.json as dependencies

"coveralls": "^3.0.2",
"cross-env": "^5.2.0",
"cz-conventional-changelog": "^2.1.0",
"fs": "^0.0.1-security",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this dependency

"jest-config": "^24.7.1",
"lint-staged": "^8.0.0",
"lodash.camelcase": "^4.3.0",
"path": "^0.12.7",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this dependency

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyoner

Removed

@pyoner pyoner merged commit 3c7b147 into pyoner:master Jul 1, 2019
@pyoner
Copy link
Owner

pyoner commented Jul 1, 2019

@soarer1004
thank you!

@pyoner
Copy link
Owner

pyoner commented Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants