Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 8, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

chfw and others added 23 commits February 22, 2019 07:49
* 🎉 new style writer

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* Update rnd_requirements.txt

* Update pyexcel-xlsxw.yml

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

Co-authored-by: chfw <chfw@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6071bde). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   98.14%           
=========================================
  Files             ?        8           
  Lines             ?      378           
  Branches          ?        0           
=========================================
  Hits              ?      371           
  Misses            ?        7           
  Partials          ?        0           
Impacted Files Coverage Δ
pyexcel_xlsxw/__init__.py 100.00% <100.00%> (ø)
pyexcel_xlsxw/xlsxw.py 100.00% <100.00%> (ø)
tests/base.py 98.18% <100.00%> (ø)
tests/test_bug_fixes.py 100.00% <100.00%> (ø)
tests/test_formatters.py 100.00% <100.00%> (ø)
tests/test_multiple_sheets.py 97.12% <100.00%> (ø)
tests/test_stringio.py 100.00% <100.00%> (ø)
tests/test_writer.py 96.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6071bde...952ab05. Read the comment docs.

@chfw chfw merged commit 543128f into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants