Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 10, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

chfw added 2 commits October 10, 2020 14:30
* 🐛 fix regression issue on writing to memory stream. fix #9

* 💄 update coding style
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           8        8           
  Lines         378      378           
=======================================
  Hits          371      371           
  Misses          7        7           
Impacted Files Coverage Δ
pyexcel_xlsxw/__init__.py 100.00% <ø> (ø)
tests/base.py 98.18% <ø> (ø)
tests/test_stringio.py 100.00% <ø> (ø)
pyexcel_xlsxw/xlsxw.py 100.00% <100.00%> (ø)
tests/test_bug_fixes.py 100.00% <100.00%> (ø)
tests/test_formatters.py 100.00% <100.00%> (ø)
tests/test_multiple_sheets.py 97.12% <100.00%> (ø)
tests/test_writer.py 96.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952ab05...a85759b. Read the comment docs.

@chfw chfw merged commit 37b706c into master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants