Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 8, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

chfw and others added 30 commits November 10, 2018 22:26
* 🎉 new style reader

* 🎉 new style writer and reader plugins

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💚 update moban update

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

* 💚 use pyexcel-io dev branch

* 📚 update PR template

* 🐴 code refactoring

Co-authored-by: chfw <chfw@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6a5a851). Click here to learn what that means.
The diff coverage is 98.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage          ?   98.40%           
=========================================
  Files             ?       13           
  Lines             ?      690           
  Branches          ?        0           
=========================================
  Hits              ?      679           
  Misses            ?       11           
  Partials          ?        0           
Impacted Files Coverage Δ
tests/_compact.py 75.00% <ø> (ø)
pyexcel_xls/xlsw.py 98.14% <95.65%> (ø)
pyexcel_xls/xlsr.py 99.24% <98.27%> (ø)
pyexcel_xls/__init__.py 100.00% <100.00%> (ø)
tests/base.py 98.21% <100.00%> (ø)
tests/test_bug_fixes.py 98.63% <100.00%> (ø)
tests/test_filter.py 100.00% <100.00%> (ø)
tests/test_formatters.py 100.00% <100.00%> (ø)
tests/test_hidden.py 100.00% <100.00%> (ø)
tests/test_merged_cells.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5a851...cfb7d3a. Read the comment docs.

@chfw chfw merged commit 9c0bbbd into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants