Problem with Efficient Loader because there are too many properties(?)

[rodneyviana]

First of all, congratulations for this amazing software. I was able to make most of it work, but there is a problem with a particular custom node. So this is the portion I believe is failing, I am attaching the workflow to this post) and the code generated,

... removed for brevity ...
    "class_type": "Eff. Loader SDXL"
  },
  "2": {
    "inputs": {
      "input_mode": "simple",
      "lora_count": 2,
      "lora_name_1": "add-detail-xl.safetensors",
      "lora_wt_1": 0.7000000000000001,
      "model_str_1": 1,
      "clip_str_1": 1,
      "lora_name_2": "xl_more_art-full_v1.safetensors",
      "lora_wt_2": 0.7000000000000001,
      "model_str_2": 1,
      "clip_str_2": 1,
      "lora_name_3": "None",
      "lora_wt_3": 1,
      "model_str_3": 1,
      "clip_str_3": 1,
      "lora_name_4": "None",
      "lora_wt_4": 1,
      "model_str_4": 1,
      "clip_str_4": 1,
      "lora_name_5": "None",
      "lora_wt_5": 1,
      "model_str_5": 1,
... removed for brevity ...

Generates:
        lora_stacker = NODE_CLASS_MAPPINGS["LoRA Stacker"]()
        lora_stacker_2 = lora_stacker.lora_stacker(input_mode="simple", lora_count=2)

        eff_loader_sdxl = NODE_CLASS_MAPPINGS["Eff. Loader SDXL"]()
        ksampler_sdxl_eff = NODE_CLASS_MAPPINGS["KSampler SDXL (Eff.)"]()
        saveimage = SaveImage()

        for q in range(10):
            eff_loader_sdxl_1 = eff_loader_sdxl.efficientloaderSDXL(
                base_ckpt_name="copaxTimelessxlSDXL1_v5.safetensors",
                base_clip_skip=-1,
                refiner_ckpt_name="sdXL_v10RefinerVAEFix.safetensors",
                refiner_clip_skip=-1,
                positive_ascore=6,
                negative_ascore=2,
                vae_name="Baked VAE",
                positive="photorealistic scene of (..removed for brevity..) freckles, realistic, wide angle,  wide shot, 4k, film grain, depth, masterpiece",
                negative="embedding:negativeXL (worst quality:1.5), (low quality:1.5), (normal quality:1.5), lowres, bad anatomy, bad hands, multiple eyebrow, (cropped), extra limb, missing limbs, deformed hands, long neck, long body, (bad hands), signature, username, artist name, conjoined fingers, deformed fingers, ugly eyes, imperfect eyes, skewed eyes, unnatural face, unnatural body, error, painting by bad-artist, asian, long hands, helmet:1.5, cgi, 3d, illustration, blue skin, unnatural skin, close up shot, out of frame ",
                empty_latent_width=1024,
                empty_latent_height=1024,
                batch_size=1,
                lora_stack=get_value_at_index(lora_stacker_2, 0),
            )

workflow_api.json.txt
workflow_api.py.txt

Notice that the number of properties on the lora is huge and only the first 2 properties are added.

[pydn]

Thank you! Do you have a link to the custom node repo? And the version you are using to create the workflow_api.json file?

[rodneyviana]

This is the repo: https://github.com/jags111/efficiency-nodes-comfyui/<https://github.com/jags111/efficiency-nodes-comfyui/blob/main/workflows/SDXL_base_refine_noise_workflow.png> I found that the crash was caused by a callback to the UI, but the problem in your application is that the Lora stack is not filling up all the available parameters. It stops at Lora count. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Peyton DeNiro ***@***.***> Sent: Monday, November 27, 2023 6:02:23 PM To: pydn/ComfyUI-to-Python-Extension ***@***.***> Cc: Author ***@***.***> Subject: Re: [pydn/ComfyUI-to-Python-Extension] Problem with Efficient Loader because there are too many properties(?) (Issue #26) Thank you! Do you have a link to the custom node repo? And the version you are using to create the workflow_api.json file? — Reply to this email directly, view it on GitHub<#26 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGT5MAXORBL75Y7HPJ65SE3YGUSY7BFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVE3DOMRWG44DOMRQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRRHE4DMNZYGIYTMMNHORZGSZ3HMVZKMY3SMVQXIZI>. You are receiving this email because you authored the thread. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[pydn]

Hi @rodneyviana this issue is likely fixed with this update that was merged to main #73.

[rodneyviana]

Thank you. I will test it in a few weeks when I am back from vacation.

…

________________________________ From: Peyton DeNiro ***@***.***> Sent: Thursday, September 12, 2024 2:37:36 PM To: pydn/ComfyUI-to-Python-Extension ***@***.***> Cc: Mention ***@***.***>; Author ***@***.***>; Comment ***@***.***> Subject: Re: [pydn/ComfyUI-to-Python-Extension] Problem with Efficient Loader because there are too many properties(?) (Issue #26) Hi @rodneyviana<https://github.com/rodneyviana> this issue is likely fixed with this update that was merged to main #73<#73>. — Reply to this email directly, view it on GitHub<#26 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGT5MAQGH5PS4WM6QIQH45TZWHNPBBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVE3DOMRWG44DOMRQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRRHE4DMNZYGIYTMMNHORZGSZ3HMVZKMY3SMVQXIZI>. You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.