feat: add [u and ]u shortcuts to go to the next/previous unviewed file during code review #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR adds
[uand]ukeybindings, which allow going to the prev/next file that is notVIEWEDduring a review.Does this pull request fix one issue?
Fixes #1152
Describe how you did it
I added handlers that go through each file until they encounter one whose
viewed_stateis notVIEWED. If no such files are found, it simply moves on to the next/previous file from the current file.Describe how to verify it
[uand]uand ensure that the viewed file(s) are skippedSpecial notes for reviews
Checklist