Feature changes #24
Open
Feature changes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and flow impact:
CloudConfig: added fallback credentials, logs secrets, exposes a public static Cloudinary instance, disables SSL verification, and includes a weak token generator — affects app startup and config flows.
UserDao: uses DriverManager with hard-coded creds, builds SQL via string concatenation, uses MD5 and logs hashes — affects user lookup/auth DB flow.
ImageService: thread-unsafe formatter, InputStream not closed, raw Map usage, and silent exception handling — affects image upload and processing.
ImageController: permissive CORS, no upload validation, and leaks exception messages — affects upload API surface and client error handling.
Hobby model: inconsistent equals/hashCode and mutable id — affects entity equality and collection behavior.