Skip to content

Fix node-streams dep; prep next release #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2022
Merged

Fix node-streams dep; prep next release #30

merged 3 commits into from
Apr 29, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes node-streams dep; preps next release

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

CC @garyb or @thomashoneyman

thomashoneyman
thomashoneyman reviewed Apr 29, 2022
View reviewed changes
CHANGELOG.md Outdated

## [v6.0.0](https://github.com/purescript-node/purescript-node-readline/releases/tag/v6.0.0) - 2022-04-27

Breaking changes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be adjusted to note the error in this release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah. let me fix that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI builds

@thomashoneyman thomashoneyman merged commit fbe80a9 into purescript-node:master Apr 29, 2022
@JordanMartinez JordanMartinez deleted the fix-streams-dep branch April 29, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman