Skip to content

New module: Data.ArrayBuffer.Cast #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2022
Merged

New module: Data.ArrayBuffer.Cast #46

merged 2 commits into from
Dec 1, 2022

Conversation

jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Nov 28, 2022 •
edited
Loading

Casting between ArrayBuffer and DataView. Resolves #45

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@jamesdbrock jamesdbrock marked this pull request as ready for review November 28, 2022 03:33
@jamesdbrock
Copy link
Member Author

I guess we could maybe do something fancy with a Fail type error for the ArrayView type? But it’s not worth it because these three cases are the only cases for this cast and there is zero chance that there will ever be any other cases.

@jamesdbrock jamesdbrock merged commit bae93c3 into main Dec 1, 2022
@jamesdbrock jamesdbrock deleted the castdataview branch December 3, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fromUint8Array, toUint8Array
2 participants
@jamesdbrock @JordanMartinez