Fix broken tests for ssl, vhost, vhost::* #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of tests were broken by the last few style commits when '755' became '0755' and the tests didn't get updated. This commit fixes the tests so that they work again. The tests for apache::ssl were broken because the 'operatingsystem' fact was not being set in the tests. Don't know how long that's been busted, but in any case this commit fixes that problem as well by adding appropriate let(:facts).
jamtur01
added a commit
that referenced
this pull request
Apr 22, 2012
Fix broken tests for ssl, vhost, vhost::*
|
Awesome marut++ |
Aethylred
pushed a commit
to nesi/puppetlabs-apache
that referenced
this pull request
Apr 15, 2013
Add custom vhost content parameter
slamont
referenced
this pull request
in slamont/puppetlabs-apache
Apr 26, 2013
Revert "Merge pull request hunner#26 from hunner/add_custom_template"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests were broken by the last few style commits when '755' became '0755' and the tests didn't get updated. This commit fixes the tests so that they work again.
The tests for apache::ssl were broken because the 'operatingsystem' fact was not being set in the tests. Don't know how long that's been busted, but in any case this commit fixes that problem as well by adding appropriate let(:facts).