(#13860) Autorequire Package['httpd'] #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, the `a2mod type did not autorequire the Package['httpd'] resource provided by the `apache` class. If the Package['httpd'] resource was enforced after any a2mod resources, the a2mod resources would fail since the httpd package installs the a2emod/a2dismod system commands.
|
@ccaum This suitability issue can be resolved by using 'optional_commands' instead of 'commands' |
| end | ||
| end | ||
|
|
||
| autorequire(:package) { catalog.resource(:package, 'httpd')} |
There was a problem hiding this comment.
is there any reason that you can't just use:
autorequire(:package) { ['httpd'] }
?
There was a problem hiding this comment.
I didn't know that was possible. I can change it to that if you'd prefer
Previous to this comit, the a2enmod and a2dismod commands were required for the a2mod provider to be used by puppet on the first run. Since these commands are not always available on the first run, the catalog application might fail. This commit makes the commands optional, so the provider's validity will be evaluated when an a2mod resource is enforced
bodepd
added a commit
that referenced
this pull request
Apr 12, 2012
(#13860) Autorequire Package['httpd']
Aethylred
pushed a commit
to nesi/puppetlabs-apache
that referenced
this pull request
Apr 15, 2013
Add ripienaar/concat dependancy to Modulefile
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
(maint)fixing syntax error in compose spec file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the
a2modtype did not autorequire thePackage['httpd'] resource provided by the
apacheclass.It turns out, since puppet checks the suitability for the provider at the beginning run of the catalog, the a2mod provider is never suitable until the second puppet run. Still, this autorequire is a good idea as I think the current master branch of puppet resolves the suitability problem.