(#13072) Move mod python and wsgi package names to params #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the compile error? The in-selector? |
|
@rcoleman I meant Syntax Error and Yes the selector was the problem. [root@marine:modules/apache]# puppet apply tests/mod_python.pp --noop Syntax error at ','; expected '}' at /etc/puppet/modules/apache/manifests/mod/python.pp:6 on node marine.cat.pdx.edu |
Previously apache::mod::python and apache::mod::wsgi used a case statement to determine which package to install. This commit moves the package names to the params class and fixes the syntax errors introduced in commit 2b79e8b when the selectors were changed to include Scientific Linux.
|
Looks good, thanks for the clarification. |
ryanycoleman
pushed a commit
that referenced
this pull request
Mar 13, 2012
…thon (#13072) Move mod python and wsgi package names to params Reviewed by Ryan Coleman (ryan@puppetlabs.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously apache::mod::python and apache::mod::wsgi used
a case statement to determine which package to install. This
commit moves the package names to the params class and fixes
the syntax errors introduced in commit 2b79e8b when the
selectors were changed to include Scientific Linux.