mod::php dep items

[strobert]

Was using the puppetlabs-apache module during a training class and I think I found a couple of dep issues.

1. If you turn off default_mods in apache:

  class { 'apache':
    default_mods  => false,
    default_vhost => false,
  }
  include 'apache::mod::php'

mod::php will create a configuration file using AddHandler and DirectoryIndex but doesn't make sure the mod providers for those are in the catalog. so you need to manually add these:

  include 'apache::mod::mime'
  include 'apache::mod::dir'

thinking that is something mod::php should do...

and
2) in mod/php.pp it has:
before => File[$apache::mod_dir],
shouldn't that be:
require => File[$apache::mod_dir], ?
I'm thinking as is it is saying the file needs to be placed in the directory before the directory gets made...

[igalic]

1. mod::proxy_ajp has this:

  Class['apache::mod::proxy'] -> Class['apache::mod::proxy_ajp']

in mod::php, we should add it after line 9.

1. Confusingly, no: File[$apacher::mod_dir](and ::confdir) actually purges all files we don't manage from the those directories, so timing wise, we want to place our modules' configuration files before that, so that puppet's catalogue knows the file before it does any purging of that directory.

[strobert]

interesting behavior (on item #2). the item #1 items were what I was investigating and sounds like you concur with those deps being needed. I just saw the item #2 line whil ein there and it made me scratch my head.

[igalic]

@strobert can you see if #422 works for you?

[igalic]

Jenkins at least, is happy

[strobert]

applied the patch locally and yup that made the exercise compile.