Projection manager, Updates & Bugfixes #59

prolic · 2017-02-26T12:55:10Z

see prooph/event-store#267

the event store PR is required for travis to turn green.

prolic · 2017-02-26T12:56:36Z

/cc @oqq

oqq

👍

oqq · 2017-02-26T14:16:25Z

src/MySqlEventStore.php

-        if (null === $factory) {
-            $factory = $this->getDefaultReadModelProjectionFactory();
+        if (null !== $filter) {
+            $where[] = '`real_stream_name` = :filter ';


unnecessary space on the end of string

oqq · 2017-02-26T14:18:33Z

src/MySqlEventStore.php

-        }
-
-        if ($regex && false === @preg_match("/$filter/", '')) {
+        if (false === @preg_match("/$filter/", '')) {


error suppression, you know. ;)

register and unregister error handler for a single line of code is much slower I think.

The whole test could be omitted and simply catched from mysql.
ERROR 1139 (42000): Got error '%s' from regexp

Not sure about postgre.

This would also fail with an empty $filter string.
preg_match("//", ''); is fine, but
SELECT 1 REGEXP '' ERROR 1139 (42000): Got error 'empty (sub)expression' from regexp

I can catch error code from postgres 2201B to check for invalid regex.
Mysql error code 42000 "Got error 'empty (sub)expression' from regexp" works for empty string, but another invalid regex is accepted without error. Another thing is error code 42000 in MySql is used for different reasons. Really bad.

So we can make this change for postgres, but not MySql so much.

What is the result for invalid regex.. no result? Thats bad :(

yep, it just returns empty result, no error code at all.

sadly.. than this extra call is necessary :(
But $filter should not be empty, too. To protect for that sql error.

already done.

oqq · 2017-02-26T14:19:20Z

src/MySqlEventStore.php

-            $where[] = '`real_stream_name` = :filter ';
-            $values[':filter'] = $filter;
-        }
+        $where[] = '`real_stream_name` REGEXP :filter ';


unnecessary space

oqq · 2017-02-26T14:23:12Z

src/PostgresEventStore.php

-        if (null === $factory) {
-            $factory = $this->getDefaultReadModelProjectionFactory();
+        if (null !== $filter) {
+            $where[] = 'real_stream_name = :filter ';


oqq · 2017-02-26T14:24:21Z

src/PostgresEventStore.php

-            $where[] = 'real_stream_name = :filter ';
-            $values[':filter'] = $filter;
-        }
+        $where[] = 'real_stream_name ~ :filter ';


oqq · 2017-02-26T14:45:42Z

src/Projection/PostgresProjectionManager.php

+    public function fetchProjectionStreamPositions(string $name): array
+    {
+        $query = <<<SQL
+SELECT position FROM $this->projectionsTable


Postgres does not allow backticks

oqq · 2017-02-26T14:45:55Z

src/Projection/PostgresProjectionManager.php

+    public function fetchProjectionState(string $name): array
+    {
+        $query = <<<SQL
+SELECT state FROM $this->projectionsTable


Postgres does not allow backticks

oqq · 2017-02-26T14:50:54Z

tests/Projection/PdoEventStoreReadModelProjectionTest.php

+        $this->expectException(InvalidArgumentException::class);
+
+        $eventStore = $this->prophesize(EventStore::class);
+        $connection = $this->prophesize(\PDO::class);


unnecessary backslash on \PDO

oqq · 2017-02-26T14:52:45Z

tests/Projection/PdoEventStoreProjectionTest.php

+        $this->expectException(InvalidArgumentException::class);
+
+        $eventStore = $this->prophesize(EventStore::class);
+        $connection = $this->prophesize(\PDO::class);


unnecessary backslash \PDO

oqq · 2017-02-26T14:53:33Z

tests/Projection/PdoEventStoreQueryTest.php

+        $this->expectException(InvalidArgumentException::class);
+
+        $eventStore = $this->prophesize(EventStore::class);
+        $connection = $this->prophesize(\PDO::class);


unnecessary backslash

oqq · 2017-02-26T16:38:26Z

src/Projection/MySqlProjectionManager.php


-        if (! empty($whereCondition)) {
-            $whereCondition = 'WHERE ' . $whereCondition;
+            $whereCondition = 'WHERE ' . implode(' AND ', $where);


Could be

$whereCondition = 'WHERE `name` = :filter'; $values[':filter'] = $filter;

oqq · 2017-02-26T16:38:59Z

src/Projection/PostgresProjectionManager.php


-        if (! empty($whereCondition)) {
-            $whereCondition = 'WHERE ' . $whereCondition;
+            $whereCondition = 'WHERE ' . implode(' AND ', $where);


Could be

$whereCondition = 'WHERE name = :filter'; $values[':filter'] = $filter;

prolic added 11 commits February 20, 2017 18:34

add projection manager

ddc1487

updated mysql projection manager and tests

d8bb288

update mysql query and read model projection tests

191243b

apply php cs fixes

d039bb0

update fetch*-methods, update tests

386c62c

update projection managers and tests

adbd5fa

make use of new AbstractProjectionManagerTest, cleanup

8575231

make use of new AbstractEventStoreProjectionTest

342dc97

some bugfixes + usage of new abstract tests

ca24b15

work on postgres

56a02a6

apply php cs fixes

bb4707c

prolic added the enhancement label Feb 26, 2017

prolic assigned codeliner Feb 26, 2017

prolic requested a review from codeliner February 26, 2017 12:55

oqq approved these changes Feb 26, 2017

View reviewed changes

cleanup

e34f181

oqq reviewed Feb 26, 2017

View reviewed changes

prolic added 4 commits February 27, 2017 02:04

minor improvements

e0b6034

apply php cs fix

41cc4aa

code style

4bc4c07

apply php cs fixes

0744095

prolic merged commit e5d8d61 into master Mar 1, 2017

prolic deleted the projection_manager branch March 1, 2017 10:46

Projection manager, Updates & Bugfixes #59

Projection manager, Updates & Bugfixes #59

Uh oh!

Conversation

prolic commented Feb 26, 2017

Uh oh!

prolic commented Feb 26, 2017

Uh oh!

oqq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oqq Feb 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oqq Feb 26, 2017 •

edited

Loading