-
Notifications
You must be signed in to change notification settings - Fork 1k
Batch runner params #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackiekazil
merged 5 commits into
projectmesa:master
from
dcunning11235:BatchRunner_params
May 7, 2019
Merged
Batch runner params #651
jackiekazil
merged 5 commits into
projectmesa:master
from
dcunning11235:BatchRunner_params
May 7, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter Product and batchrunner.ParameterSampler. Made a couple of fixes in ParameterSampler as a result.
1 similar comment
@dcunning11235 ty for the PR. We have a few complex issues happening at the moment. We didn't forget about you. It may take us a few days to get to review/discuss this. Hang tight! |
looks good! @jackiekazil - review complete; nothing blocking added #676 to backlog for only enhancement I saw. |
Great! |
Corvince
added a commit
that referenced
this pull request
May 21, 2019
Resources #651 in docs branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that I think satisfies #607
Added two new utility classes (ParameterProduct, ParameterSampler) for creating parameter combinations, and a base class FixedBatchRunner, which is now the super for BatchRunner, that takes a list(-like) of parameter combinations to run.