-
-
Notifications
You must be signed in to change notification settings - Fork 137
README update for alpha release #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
| yarn: | ||
|
|
||
| ```bash | ||
| yarn add --dev prettier/prettier prettier/plugin-php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we prefer global installation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czosel Let's do this as do prettier here https://prettier.io/docs/en/install.html
3c1ad79 to
e731144
Compare
README.md
Outdated
| and then run it via | ||
|
|
||
| ```bash | ||
| yarn run prettier path/to/file.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need the --write here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fixed
README.md
Outdated
|
|
||
| ```json | ||
| scripts: { | ||
| "prettier":"prettier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need glob ({**/*,*}.php) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not when you're calling it like instructed below: yarn run prettier path/to/file.php --write
mgrip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! should we leave this open until we verify all of this actually works? 😆
|
I just tried the local installation with |
|
Alright, let's do this 😄 Most important question: What are we calling the version? |
|
My vote would be |
|
@czosel I'd say feel free to publish on npm and update the package.json as part of this PR |
|
Amazing 🎉 awesome work guys! |
|
Awesome! 🎉 |
Fixes #356