Expose connection for workers #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
force-pushed
the
expose-worker-connection
branch
from
83c0e05 to
aedd45b
Compare
|
@simolus3 Thanks for this. You don't have to do the versioning and changelog in this PR, we will update and release it once the changes are merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
exposeEndpoint()method on the web, which returns a record of values that can be sent across workers on the web. It also adds a new method that takes this sent record to open another database connection to the same source, which then shares the existing connection and mutex.This is useful to allow a worker to connect to a database already opened by a client, such as for the sync worker in the Powersync SDK. A remaining issue is related to lifetimes: When the original connection closes and disposes the worker, the exposed endpoint will also close.
sqlite3_webinternally uses web locks to detect this condition, but it's not yet exposed in this package.