Sqlite Prototype #43
Merged
Sqlite Prototype #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
1 task
* Custom requests for execute in transactions * Clean up js to dart * remove requirement for checking SQL statements when checking autocommit --------- Co-authored-by: Steven Ontong <steven@journeyapps.com>
| } | ||
|
|
||
| // Web and native have different requirements for `sqlitePaths`. | ||
| void generateSourceTableTests(List<String> sqlitePaths, |
There was a problem hiding this comment.
can this not be extracted into a test_utils or something since it's used elsewhere?
There was a problem hiding this comment.
It's only currently used for the watch tests. I don't think it's currently necessary in other tests.
DominicGBauer
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an extension of #27 where the prototype is extended with some internal changes.
Drift
Drift was previously used to spawn SQLite database connections via different configurations of web workers.
The dependency for the
Driftpackage is now removed in favour of using the newsqlite3_webpackage. A new implementation forWebDatabaseis used for SQL database connections on web.