Skip to content

Conversation

rkistner
Copy link
Contributor

@rkistner rkistner commented Oct 17, 2024

The is a combination of multiple related issues:

  1. To detect whether we should trigger a crud upload iteration, the entire database was watched, instead of only the ps_crud table.
  2. Update notifications were not throttled at all on web, and not correctly handled during transactions (see Debounce update notifications sqlite_async.dart#68 for the issue and fix).
  3. The connection status was changed to uploading: true whenever we get an update notification, rather than only when there is something to upload.

The result was that on Flutter web, after an initial sync of 10k+ rows, there would be a couple of seconds of the sync indicator flickering between "uploading" and "connected". This also added performance overhead.

TODO:

@rkistner rkistner changed the base branch from benchmarks to main October 28, 2024 09:27
@rkistner rkistner marked this pull request as ready for review October 28, 2024 10:46
@rkistner rkistner requested a review from mugikhan October 28, 2024 11:24
Copy link
Contributor

@mugikhan mugikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rkistner rkistner merged commit fb2f312 into main Oct 28, 2024
4 checks passed
@rkistner rkistner deleted the fix-crud-issues branch October 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants