Add checking enable-nls option in configure #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p_6 we need skip this test if PostgreSQL configured without --enable-nls
avaness
approved these changes
Jun 28, 2022
avaness
reviewed
Jun 28, 2022
tests/helpers/ptrack_helpers.py
Outdated
| else: | ||
| return False | ||
|
|
||
| def enable_nls(): |
There was a problem hiding this comment.
please rename to check_enable_nls() or something like this
tests/helpers/ptrack_helpers.py
Outdated
Comment on lines
112
to
115
| if b'enable-nls' in p.communicate()[0]: | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Why not
Suggested change
| if b'enable-nls' in p.communicate()[0]: | |
| return True | |
| else: | |
| return False | |
| return b'enable-nls' in p.communicate()[0] |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For correct work test_help_6 we need skip this test if PostgreSQL configured without --enable-nls