Uncaught ReferenceError: subject is not defined when manually specifying thread ID

[jchampio]

0f23363 introduced an automatic Subject when attaching a patch, but the subject variable isn't defined in all code paths. So if you manually specify the thread ID in the popup window, you get

commitfest.js?v=3bcba516-f6c7-474f-9251-99f62bc34d68:75 Uncaught ReferenceError: subject is not defined
    at HTMLAnchorElement.<anonymous> (commitfest.js?v=3bcba516-f6c7-474f-9251-99f62bc34d68:75:31)
    at HTMLAnchorElement.dispatch (jquery.js:3:28337)
    at v.handle (jquery.js:3:25042)

and a hanging dialog spinner.

[nbyavuz]

Hi,

I didn't test this manually as I don't have required environment to run project but fix could be:

---
 media/commitfest/js/commitfest.js | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/media/commitfest/js/commitfest.js b/media/commitfest/js/commitfest.js
index 158e572..c92e1db 100644
--- a/media/commitfest/js/commitfest.js
+++ b/media/commitfest/js/commitfest.js
@@ -60,14 +60,15 @@ function browseThreads(attachfunc, closefunc) {
         msgid = $("#attachThreadMessageId").val();
         if (!msgid || msgid === "") {
             msgid = $("#attachThreadList").val();
-            if (!msgid) return;
-            subject = $("#attachThreadList option:selected").data("subject");
-            subject = subject.replace(/\bre: /gi, "");
-            subject = subject.replace(/\bfwd: /gi, "");
-            // Strips [PATCH], [POC], etc. prefixes
-            subject = subject.replace(/\[\w+\]: /gi, "");
-            subject = subject.replace(/\[\w+\] /gi, "");
         }
+        if (!msgid) return;
+
+        subject = $("#attachThreadList option:selected").data("subject");
+        subject = subject.replace(/\bre: /gi, "");
+        subject = subject.replace(/\bfwd: /gi, "");
+        // Strips [PATCH], [POC], etc. prefixes
+        subject = subject.replace(/\[\w+\]: /gi, "");
+        subject = subject.replace(/\[\w+\] /gi, "");
 
         $("#attachThreadListWrap").addClass("loading");
         $("#attachThreadSearchButton").addClass("disabled");
--