Skip to content

Modernize react-plotly.js and support plotly.js-dist-min v2 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Modernize react-plotly.js and support plotly.js-dist-min v2 #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
41ee392
Update deps and convert factory to TypeScript
brammitch Dec 8, 2023
49c7812
Build with tsup and convert to ESM
brammitch Dec 8, 2023
144a6c6
Remove unused file
brammitch Dec 8, 2023
02274fe
Update build output
brammitch Dec 8, 2023
26accc6
Fix issues with gd, resizeHandler, refs
brammitch Dec 8, 2023
10c694f
Cleanup eslint config
brammitch Dec 8, 2023
795c5cf
Update .gitignore
brammitch Dec 8, 2023
1cf22c1
Setup vitest and RTL
brammitch Dec 8, 2023
1c3b263
Get all tests working
brammitch Dec 8, 2023
d0f80e7
Cleanup configs, add notes
brammitch Dec 8, 2023
363eae7
Fix include
brammitch Dec 8, 2023
15b112a
Cleanup tests
brammitch Dec 8, 2023
7ab6dce
Simplfy updates to reduce rerenders
brammitch Dec 8, 2023
6f3a539
Use LTS Node version
brammitch Dec 9, 2023
fc40c6e
Supercede legacy image name
brammitch Dec 9, 2023
d35804f
Fix vulnerability in package-lock
brammitch Feb 8, 2024
253c5e9
Require node v18 (verified with `ls-engines`)
brammitch Feb 8, 2024
e7036b1
Update references to installing plotly.js
brammitch Feb 8, 2024
088485f
v3.0.0
brammitch Feb 8, 2024
5b47c2b
Add engine to package-lock
brammitch Feb 25, 2024
500a343
Change `.cjs` output to `.js`
brammitch Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .babelrc
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.0
jobs:
build:
docker:
- image: circleci/node:12.18.3
- image: cimg/node:20.9.0
working_directory: ~/react-plotly.js
steps:
- checkout
Expand Down Expand Up @@ -32,7 +32,7 @@ jobs:

test:
docker:
- image: circleci/node:12.18.3
- image: cimg/node:20.9.0
working_directory: ~/react-plotly.js
steps:
- checkout
Expand Down
279 changes: 10 additions & 269 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,295 +1,36 @@
{
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:react/recommended",
"plugin:react-hooks/recommended",
"prettier"
],
"settings": {
"react": {
"pragma": "React",
"version": "detect"
}
},
"parser": "babel-eslint",
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"ecmaVersion": "latest",
"sourceType": "module",
"ecmaFeatures": {
"arrowFunctions": true,
"blockBindings": true,
"classes": true,
"defaultParams": true,
"destructuring": true,
"forOf": true,
"generators": true,
"modules": true,
"templateStrings": true,
"jsx": true
}
"project": ["./tsconfig.json", "./tsconfig.node.json"]
},
"env": {
"browser": true,
"es6": true,
"jasmine": true,
"jest": true,
"es2020": true,
"node": true
},
"globals": {
"jest": true
},
"plugins": [
"react",
"import"
],
"plugins": ["@typescript-eslint", "react", "import"],
"rules": {
"accessor-pairs": [
"error"
],
"block-scoped-var": [
"error"
],
"consistent-return": [
"error"
],
"curly": [
"error",
"all"
],
"default-case": [
"error"
],
"dot-location": [
"off"
],
"dot-notation": [
"error"
],
"eqeqeq": [
"error"
],
"guard-for-in": [
"off"
],
"import/named": [
"off"
],
"import/no-duplicates": [
"error"
],
"import/no-named-as-default": [
"error"
],
"new-cap": [
"error"
],
"no-alert": [
1
],
"no-caller": [
"error"
],
"no-case-declarations": [
"error"
],
"no-console": [
"error"
],
"no-div-regex": [
"error"
],
"no-dupe-keys": [
"error"
],
"no-else-return": [
"error"
],
"no-empty-pattern": [
"error"
],
"no-eq-null": [
"error"
],
"no-eval": [
"error"
],
"no-extend-native": [
"error"
],
"no-extra-bind": [
"error"
],
"no-extra-boolean-cast": [
"error"
],
"no-inline-comments": [
"error"
],
"no-implicit-coercion": [
"error"
],
"no-implied-eval": [
"error"
],
"no-inner-declarations": [
"off"
],
"no-invalid-this": [
"error"
],
"no-iterator": [
"error"
],
"no-labels": [
"error"
],
"no-lone-blocks": [
"error"
],
"no-loop-func": [
"error"
],
"no-multi-str": [
"error"
],
"no-native-reassign": [
"error"
],
"no-new": [
"error"
],
"no-new-func": [
"error"
],
"no-new-wrappers": [
"error"
],
"no-param-reassign": [
"error"
],
"no-process-env": [
"warn"
],
"no-proto": [
"error"
],
"no-redeclare": [
"error"
],
"no-return-assign": [
"error"
],
"no-script-url": [
"error"
],
"no-self-compare": [
"error"
],
"no-sequences": [
"error"
],
"no-shadow": [
"off"
],
"no-throw-literal": [
"error"
],
"no-undefined": [
"error"
],
"no-unused-expressions": [
"error"
],
"no-use-before-define": [
"error",
"nofunc"
],
"no-useless-call": [
"error"
],
"no-useless-concat": [
"error"
],
"no-with": [
"error"
],
"prefer-const": [
"error"
],
"radix": [
"error"
],
"react/jsx-no-duplicate-props": [
"error"
],
"react/jsx-no-undef": [
"error"
],
"react/jsx-uses-react": [
"error"
],
"react/jsx-uses-vars": [
"error"
],
"react/no-did-update-set-state": [
"error"
],
"react/no-direct-mutation-state": [
"error"
],
"react/no-is-mounted": [
"error"
],
"react/no-unknown-property": [
"error"
],
"react/prefer-es6-class": [
"error",
"always"
],
"react/prop-types": "error",
"valid-jsdoc": [
"error"
],
"yoda": [
"error"
],
"spaced-comment": [
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": [
"error",
"always",
{
"block": {
"exceptions": [
"*"
]
}
}
],
"no-unused-vars": [
"error",
{
"args": "after-used",
"argsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^e$"
}
],
"no-magic-numbers": [
"error",
{
"ignoreArrayIndexes": true,
"ignore": [
-1,
0,
1,
2,
3,
100,
10,
0.5
]
"varsIgnorePattern": "^_"
}
],
"no-underscore-dangle": [
"off"
]
}
}
6 changes: 0 additions & 6 deletions .gitattributes
View file
Open in desktop

This file was deleted.

25 changes: 2 additions & 23 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,3 @@
node_modules

npm-debug.log*
*.sublime*

.*
!.circleci
!.gitignore
!.gitattributes
!.npmignore
!.eslintrc
!.babelrc
!.eslintignore

coverage
dist
!example/dist

package-lock.json.*

factory.js
factory.js.map
react-plotly.js
react-plotly.js.map
yarn.lock
node_modules
13 changes: 0 additions & 13 deletions .npmignore
View file
Open in desktop

This file was deleted.

Loading