Skip to content

Fix heatmap issues used in ssim baselines matlab code examples data distribution plots heatmap #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gilbertogalvis
Copy link
Contributor

@VolKa79
Copy link

VolKa79 commented Aug 23, 2021

Tested for all from
https://github.com/plotly/ssim_baselines/tree/main/matlab/code-examples/data-distribution-plots/heatmap
Looks good, of course except of ansence of that black separate lines
heat1

And with the last function, where:
tbl = readtable('TemperatureData.csv');
months = categorical(tbl.Month);
years = categorical(tbl.Year);
xlabels = categories(months);
ylabels = categories(years);
nummonths = numel(xlabels);
numyears = numel(ylabels);
x = double(months);
y = double(years);
temps = tbl.TemperatureF;
cdata = accumarray([y,x],temps,[numyears,nummonths],@max,NaN);
h = heatmap(xlabels,ylabels,cdata);

we have an issue with NaN values
heat2

@gilbertogalvis
Copy link
Contributor Author

Tested for all from
https://github.com/plotly/ssim_baselines/tree/main/matlab/code-examples/data-distribution-plots/heatmap
Looks good, of course except of ansence of that black separate lines
heat1

And with the last function, where:
tbl = readtable('TemperatureData.csv');
months = categorical(tbl.Month);
years = categorical(tbl.Year);
xlabels = categories(months);
ylabels = categories(years);
nummonths = numel(xlabels);
numyears = numel(ylabels);
x = double(months);
y = double(years);
temps = tbl.TemperatureF;
cdata = accumarray([y,x],temps,[numyears,nummonths],@max,NaN);
h = heatmap(xlabels,ylabels,cdata);

we have an issue with NaN values
heat2

Excellent! Thanks a lot for test it @VolKa79. That's observations are good! I will hope it.

For now I will merge this with the master and in the future I will try to fix it. For now this works to upscale the SSIM for heatmap

@gilbertogalvis gilbertogalvis merged commit d3a5175 into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants