Config options update #2199
Config options update #2199
Conversation
doc/python/configuration-options.md
Outdated
| fig.show(config=config) | ||
| ``` | ||
|
|
||
| ### Display The `Edit In Chart Studio` Modebar Button |
There was a problem hiding this comment.
Not clear to me how this is different from the previous example?
There was a problem hiding this comment.
This example has a button in the modebar rather than the hyperlink in the bottom right of the figure.
There was a problem hiding this comment.
ok, maybe add a sentence here and above, and/or have the two examples in the same section?
doc/python/configuration-options.md
Outdated
| fig.show(config=config) | ||
| ``` | ||
|
|
||
| ##### Making A Responsive Chart |
There was a problem hiding this comment.
This one would deserve more explanations I think: define responsiveness, and comment on figure behaviour when it's responsive. For example when I tried this config parameter does not make a figure responsive (resized when winodw is resized) in a Jupyter notebook, but in a Dash app the figure is responsive by default?
There was a problem hiding this comment.
Looking at this example, I think it actually makes more sense to make it about how to disable the default responsive behavior that figures have.
I'm surprised figures aren't responsive in your Jupyter notebook- they are in mine 🤔
|
Thank you @jdamiba this is a very useful addition! I left some minor comments. |
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
binder/requirements.txt
Outdated
| @@ -14,3 +14,5 @@ networkx | |||
| scikit-image | |||
| datashader | |||
| pyarrow | |||
| dash_core_components | |||
| dash_html_components | |||
There was a problem hiding this comment.
oh and dash as well :-)
doc/requirements.txt
Outdated
| @@ -24,3 +24,5 @@ pathlib | |||
| python-frontmatter | |||
| datashader | |||
| pyarrow | |||
| dash_core_components | |||
| dash_html_components | |||
|
@nicolaskruchten Can you please take another look at this? I reverted the style issues we are talked about in our meeting earlier this week. |
|
@nicolaskruchten would you like me to take hover reviewing this PR? It would be great to merge it. |
|
@emmanuelle yes please :) |
|
Thank you @jdamiba ! This looks good to me 💃. For the "what about Dash" paragraph, is there a way to remove it since you already mention Dash? This can be done later anyway. |
|
I fixed a merge conflict BTW. |
The purpose of this PR is twofold: