Skip to content

Use plotly.min.js in both JS bundles #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Use plotly.min.js in both JS bundles #2103

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1494a25
both bundles use min
nicolaskruchten Jan 20, 2020
304745e
clean up package.json build steps
nicolaskruchten Jan 20, 2020
16b5f0b
explicitly run webpack in plotlywidget
nicolaskruchten Jan 20, 2020
209daab
explicitly run webpack in plotlywidget
nicolaskruchten Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
explicitly run webpack in plotlywidget
  • Loading branch information
@nicolaskruchten
nicolaskruchten committed Jan 20, 2020
commit 16b5f0b8b24847ebf534d7a9944bc2733f6a9558
6 changes: 6 additions & 0 deletions packages/python/plotly/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ def run(self):
stdout=sys.stdout,
stderr=sys.stderr,
)
check_call(
[npmName, "run build"],
cwd=node_root,
stdout=sys.stdout,
stderr=sys.stderr,
)
os.utime(self.node_modules, None)

for t in self.targets:
Expand Down