Skip to content

standardize on df variable name #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2019
Merged

standardize on df variable name #2007

merged 2 commits into from
Dec 17, 2019

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

emmanuelle
emmanuelle reviewed Dec 17, 2019
View reviewed changes
@nicolaskruchten
Copy link
Contributor Author

FYI my search'n'replace approach only targets the datasets in px.data and not others we may have named while loading from files etc... should be a pretty good start though!

Do you recall any other names we may have used repeatedly?

@nicolaskruchten nicolaskruchten merged commit 39ac9f3 into doc-prod Dec 17, 2019
@emmanuelle
Copy link
Contributor

I did a grep "pd.read_csv('https" * and only found a couple of places where it's not df or df_something, like milk_data in peak_finding.md

@nicolaskruchten nicolaskruchten deleted the standardize_on_df branch June 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@emmanuelle emmanuelle emmanuelle left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaskruchten @emmanuelle