Skip to content

Remove "paper" as default reference when adding annotations/shapes/images #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove type annotation comments not supported by latest black
pin black version in pre-commit-config.yaml
  • Loading branch information
jonmmease committed Nov 11, 2019
commit 7c40e34786c4dec81020dc59732c0d1c452af162
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/ambv/black
rev: stable
rev: 19.10b0
hooks:
- id: black
language_version: python
language_version: python
11 changes: 0 additions & 11 deletions packages/python/plotly/plotly/basedatatypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,14 +252,11 @@ class is a subclass of both BaseFigure and widgets.DOMWidget.
# Dict from trace indexes to trace edit dicts. These trace edit dicts
# are suitable as `data` elements of Plotly.animate, but not
# the Plotly.update (See `_build_update_params_from_batch`)
#
# type: OrderedDict[int, OrderedDict[str, typ.Any]]
self._batch_trace_edits = OrderedDict()

# ### Batch layout edits ###
# Dict from layout properties to new layout values. This dict is
# directly suitable for use in Plotly.animate and Plotly.update
# type: collections.OrderedDict[str, typ.Any]
self._batch_layout_edits = OrderedDict()

# Animation property validators
Expand Down Expand Up @@ -2984,38 +2981,32 @@ def __init__(self, plotly_name, **kwargs):
# ---------------------
# ### _validators ###
# A dict from property names to property validators
# type: Dict[str, BaseValidator]
self._validators = {}

# ### _compound_props ###
# A dict from compound property names to compound objects
# type: Dict[str, BasePlotlyType]
self._compound_props = {}

# ### _compound_array_props ###
# A dict from compound array property names to tuples of compound
# objects
# type: Dict[str, Tuple[BasePlotlyType]]
self._compound_array_props = {}

# ### _orphan_props ###
# A dict of properties for use while object has no parent. When
# object has a parent, it requests its properties dict from its
# parent and doesn't use this.
# type: Dict
self._orphan_props = {}

# ### _parent ###
# The parent of the object. May be another BasePlotlyType or it may
# be a BaseFigure (as is the case for the Layout and Trace objects)
# type: Union[BasePlotlyType, BaseFigure]
self._parent = None

# ### _change_callbacks ###
# A dict from tuples of child property path tuples to lists
# of callbacks that should be executed whenever any of these
# properties is modified
# type: Dict[Tuple[Tuple[Union[str, int]]], List[Callable]]
self._change_callbacks = {}

def _process_kwargs(self, **kwargs):
Expand Down Expand Up @@ -3831,7 +3822,6 @@ def _set_compound_prop(self, prop, val):
# Import value
# ------------
validator = self._validators.get(prop)
# type: BasePlotlyType
val = validator.validate_coerce(val, skip_invalid=self._skip_invalid)

# Save deep copies of current and new states
Expand Down Expand Up @@ -3906,7 +3896,6 @@ def _set_array_prop(self, prop, val):
# Import value
# ------------
validator = self._validators.get(prop)
# type: Tuple[BasePlotlyType]
val = validator.validate_coerce(val, skip_invalid=self._skip_invalid)

# Save deep copies of current and new states
Expand Down