Skip to content

apply defaults cascade to swatches() #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2019
Merged

apply defaults cascade to swatches() #1886

merged 4 commits into from
Nov 11, 2019

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

@nicolaskruchten
Copy link
Contributor Author

Supersedes #1872 except for the title ... @joelostblom what do you think of this? It now respects pio.templates.default and px.default.templates and lets you override inline with a template kwarg. These swatches basically can't be made as px.bar figures so this is probably the next best thing

@nicolaskruchten
Copy link
Contributor Author

And I've fixed the title.

joelostblom
joelostblom reviewed Nov 10, 2019
View reviewed changes
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well for me, thanks!

@nicolaskruchten @joelostblom
Apply suggestions from code review
81a56c5 
Co-Authored-By: Joel Ostblom <joelostblom@users.noreply.github.com>
@emmanuelle
Copy link
Contributor

emmanuelle commented Nov 11, 2019 •
edited
Loading

Looks good to me, thanks! 💃

@nicolaskruchten nicolaskruchten merged commit 1ca5ba8 into master Nov 11, 2019
@emmanuelle emmanuelle mentioned this pull request Nov 11, 2019
Closed
@nicolaskruchten nicolaskruchten deleted the swatch_templates branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelostblom joelostblom joelostblom left review comments

@emmanuelle emmanuelle Awaiting requested review from emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaskruchten @emmanuelle @joelostblom